Open
Conversation
toots
force-pushed
the
better-once
branch
3 times, most recently
from
ffb9de2 to
de470c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
onceimplementation has a race condition: if the source to play from is not readily available, thesequencemoves to the next source and never comes back.This can be fixed with either a
switchorsource.dynamic. I chosesource.dynamicbecause we want to use this operator as the base operator for a bunch on higher level things from now on.The whole
preparesource reference round trip still isn't super easy but it's a good compromise for now.