Make purging the limits.d directory optional.#2
Closed
metcalfc wants to merge 1 commit intosaz:masterfrom
metcalfc:feature/no_purge
Closed
Make purging the limits.d directory optional.#2metcalfc wants to merge 1 commit intosaz:masterfrom metcalfc:feature/no_purge
metcalfc wants to merge 1 commit intosaz:masterfrom
metcalfc:feature/no_purge
Conversation
ghost
assigned
Contributor
Author
|
@saz Any chance this can get upstream? I need to not purge the limits directory. I'd rather not fork. |
Contributor
Author
|
Well that didn't have the desired effect. But the commit e5e4bc5 hopefully addresses your review. I've pulled the param out of params and pass it directly to config now. The default is still purge to remain backwards compatible. |
Many packages install files into the limits.d directory. Allow the user to decide if they want to purge non puppet managed files.
Contributor
Author
|
There fixed it. Sorry. Pull requests with review edits are new for me. |
Owner
|
I've decided to rewrite the whole module as a parameterized class. Please have a look at it. |
Contributor
Author
|
Looks good. Closing for dup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many packages install files into the limits.d directory. Allow the user to
decide if they want to purge non puppet managed files.
The default stays purging to keep backwards compatibility.