Skip to content

refactored for Puppet 4 / Hiera 5#30

Merged
saz merged 4 commits intosaz:masterfrom
crayfishx:feature/hiera5
Jan 9, 2018
Merged

refactored for Puppet 4 / Hiera 5#30
saz merged 4 commits intosaz:masterfrom
crayfishx:feature/hiera5

Conversation

@crayfishx
Copy link
Contributor

Summary

This is a refactor to modernize/refresh this module to work with Hiera 5 / Puppet 4.

Changes

  • Removed params.pp pattern, replaced with Hiera 5 data-in-modules
  • Removed hiera_hash() function calls, replaced with lookup_options in Hiera data
  • Removed create_resources() function call, replaced with iterator
  • Enhanced type validation on all parameters using native data types (note: hard/soft/both parameters are now required as integers, which matches the original documentation)
  • Added more documentation around parameters
  • Removed test coverage for Puppet 3 and added Puppet 5

It would be nice to get this merged - the module seems a bit dated as-is with use of deprecated features like hiera_hash....

@ggeldenhuis
Copy link

Yes please! Lets leave the dark ages of create_resources behind.

@saz saz merged commit 25eb284 into saz:master Jan 9, 2018
@saz
Copy link
Owner

saz commented Jan 9, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants