Merged
Conversation
bschonec
force-pushed
the
manage_limits_file
branch
from
0d14b3a to
5ecc4be
Compare
bschonec
force-pushed
the
manage_limits_file
branch
3 times, most recently
from
1a7ee01 to
2110e63
Compare
saz
reviewed
Apr 29, 2023
metadata.json
Outdated
| ], | ||
| "dependencies": [ | ||
| { | ||
| "name": "puppetlabs/stdlib", |
Contributor
Author
There was a problem hiding this comment.
I would argue that stdlib has always been a requirement but because stdlib is ubiquitous that it's never been an issue before. Since some of my changes include specifying data types, stdlib datatypes is required.
Owner
There was a problem hiding this comment.
I don't see any usage of stdlib within the module right now and there's nothing special in your PR, which makes use of stdlib. Data types are "native" to Puppet and don't require the stdlib module.
Contributor
Author
There was a problem hiding this comment.
I've removed the dependency. Thanks for that info.
bschonec
force-pushed
the
manage_limits_file
branch
from
2110e63 to
dbf8478
Compare
jay7x
added a commit
to jay7x/puppet-limits
that referenced
this pull request
Oct 17, 2024
Module hiera contains reference to a non-existent template (introduced in saz#44)
saz
pushed a commit
that referenced
this pull request
Oct 18, 2024
Module hiera contains reference to a non-existent template (introduced in #44)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the management of the /etc/security/limits.conf file.
I used a RHEL7 limits.conf file as a "generic" template because I don't have access to Amazon, Gentoo or other non-RHEL-type OSes. These templates can be added easily in the future if desired. The limits.conf file would normally be devoid of anything other that commented-out examples and any limits would be managed in /etc/security/limits.d/ files.