Skip to content

Implement creator applications #6084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smarter merged 17 commits into from
Mar 28, 2019
Merged

Implement creator applications #6084

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7c74ea5
Make TypeErrors sticky
odersky Mar 5, 2019
7ca527b
Don't try dynamic calls for type selections.
odersky Mar 5, 2019
54441d6
Generalize ExtMethodApply to IntegratedTypeArgs
odersky Mar 7, 2019
7cf15bc
Fallback from A to new A
odersky Mar 5, 2019
5ce951f
Add NameOps methods testing for anonymous classes and functions
odersky Mar 11, 2019
996424e
Code simplification
odersky Mar 12, 2019
5d8725d
Don't issue double def errors involving absent members
odersky Mar 12, 2019
a989de8
Improve treatment of typedArgs
odersky Mar 28, 2019
b864fdf
Improve toString for TypeState
odersky Mar 12, 2019
7dae38f
Fix constraint merges with conflicting type variables
odersky Mar 16, 2019
4eab6bf
Add fallback `E -> new E` if typing an applied function fails
odersky Mar 16, 2019
c453c30
Allow `new` conversion only for paths
odersky Mar 16, 2019
8ec0d1d
Fix new insertion for Selects
odersky Mar 16, 2019
69997bd
Fix handling of creator applications with type arguments
odersky Mar 17, 2019
928b014
Add docs
odersky Mar 26, 2019
7f8f382
Address review coments
odersky Mar 27, 2019
52f2e63
Fix test
odersky Mar 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't try dynamic calls for type selections. 
Without this change, tests/neg/applydynamic_sip.scala fails once
creator applications are introduced.
  • Loading branch information
@odersky
odersky committed Mar 27, 2019
commit 7ca527bcc7f9bfa7d857ae001eab91f00b5bdbc5
4 changes: 2 additions & 2 deletions compiler/src/dotty/tools/dotc/typer/TypeAssigner.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ trait TypeAssigner {
val d2 = pre.nonPrivateMember(name)
if (reallyExists(d2) && firstTry)
test(NamedType(pre, name, d2), false)
else if (pre.derivesFrom(defn.DynamicClass)) {
else if (pre.derivesFrom(defn.DynamicClass) && name.isTermName) {
TryDynamicCallType
} else {
val alts = tpe.denot.alternatives.map(_.symbol).filter(_.exists)
Expand Down Expand Up @@ -238,7 +238,7 @@ trait TypeAssigner {
val mbr = qualType.member(name)
if (reallyExists(mbr))
qualType.select(name, mbr)
else if (qualType.derivesFrom(defn.DynamicClass) && !Dynamic.isDynamicMethod(name))
else if (qualType.derivesFrom(defn.DynamicClass) && name.isTermName && !Dynamic.isDynamicMethod(name))
TryDynamicCallType
else if (qualType.isErroneous || name.toTermName == nme.ERROR)
UnspecifiedErrorType
Expand Down