Skip to content

Defining --no-dynamic-ip command line flag and NoDynamicIP member of …#284

Closed
ElNounch wants to merge 1 commit into
scaleway:masterfrom
ElNounch:no-dynamic-ip
Closed

Defining --no-dynamic-ip command line flag and NoDynamicIP member of …#284
ElNounch wants to merge 1 commit into
scaleway:masterfrom
ElNounch:no-dynamic-ip

Conversation

@ElNounch
Copy link
Copy Markdown

…struct CreateArgs

@moul
Copy link
Copy Markdown

moul commented Feb 21, 2016

Related with #283, @QuentinPerez can you check both pull-requests at the same time ?

@QuentinPerez
Copy link
Copy Markdown

Hi @ElNounch thank you for your PRs

With this solution, we have a conflict between --no-dynamic and --ip-address

$> ./scw create --no-dynamic-ip --ip-address='212.47.226.27' ubuntu-wily
$> ./scw inspect 00000000-0000-1000-0000-000000000000| jq '.[0].public_ip'
{
  "id": "00000000-0000-1000-0000-000000000000",
  "address": "212.47.226.27",
  "dynamic": false
}

Personally, I prefer this solution #283, I think that it is more readable and does not add complexity

@QuentinPerez
Copy link
Copy Markdown

We have merged #283 instead

@ElNounch ElNounch deleted the no-dynamic-ip branch February 25, 2016 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants