feat(document): download attached images in document view#219
Merged
Conversation
Document view's rendered/raw output now downloads inline images and Linear-upload links to the same /tmp cache used by issue view, so terminal renderers and downstream tools see local file paths instead of remote URLs that require auth. Image helpers (extractImageInfo, extractLinearLinkInfo, replaceImageUrls, getUrlHash, getLinearUploadHost, downloadMarkdownImages) move from src/commands/issue/issue-view.ts to src/utils/markdown-images.ts so both commands share one implementation. downloadIssueImages becomes downloadMarkdownImages, which takes an array of markdown sources rather than an issue-specific (description, comments) tuple. Adds --no-download to document view (mirroring issue view) and reorders the command so the download step runs after the --json early return but before --raw, matching issue view's behavior where piped output also gets local paths. Also adds remark-gfm to the parse/stringify pipeline used by replaceImageUrls so GFM constructs (task lists, tables, strikethrough) survive the URL rewrite. Without it, remark-stringify would re-escape `- [ ] todo` as `* \[ ] todo` whenever an image is rewritten, mangling documents and issue descriptions that lean on GFM syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document view's rendered/raw output now downloads inline images and Linear-upload links to the same /tmp cache used by issue view, so terminal renderers and downstream tools see local file paths instead of remote URLs that require auth.
Image helpers (extractImageInfo, extractLinearLinkInfo, replaceImageUrls, getUrlHash, getLinearUploadHost, downloadMarkdownImages) move from src/commands/issue/issue-view.ts to src/utils/markdown-images.ts so both commands share one implementation. downloadIssueImages becomes downloadMarkdownImages, which takes an array of markdown sources rather than an issue-specific (description, comments) tuple.
Adds --no-download to document view (mirroring issue view) and reorders the command so the download step runs after the --json early return but before --raw, matching issue view's behavior where piped output also gets local paths.
Also adds remark-gfm to the parse/stringify pipeline used by replaceImageUrls so GFM constructs (task lists, tables, strikethrough) survive the URL rewrite. Without it, remark-stringify would re-escape
- [ ] todoas* \[ ] todowhenever an image is rewritten, mangling documents and issue descriptions that lean on GFM syntax.