Skip to content

Update sunpy calendar #801

Merged
bsipocz merged 7 commits into
scientific-python:mainfrom
nabobalis:sunpy
Sep 8, 2025
Merged

Update sunpy calendar #801
bsipocz merged 7 commits into
scientific-python:mainfrom
nabobalis:sunpy

Conversation

@nabobalis

@nabobalis nabobalis commented Sep 8, 2025

Copy link
Copy Markdown
Member

Just a few old urls

Comment thread calendars/sunpy.yaml Outdated
Comment on lines +6 to +8
It is always at 5pm British Time (UTC+1 in the summer, UTC in the winter) on Wednesdays.
begin: 2022-07-20 17:00:00 +00:00
end: 2022-07-20 18:00:00 +00:00

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to handle this fact in the calendar

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can handle it now, but please do open a feature request for the problem in https://github.com/scientific-python/yaml2ics

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, keep it as 16:00 as that will be the UTC for right now (and then in practice we go back and forth between the two time slot)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened the issue, though I'm not sure if there will be a solution: scientific-python/yaml2ics#121

@netlify

netlify Bot commented Sep 8, 2025

Copy link
Copy Markdown

Deploy Preview for scientific-python-org ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2d46ec5
🔍 Latest deploy log https://app.netlify.com/projects/scientific-python-org/deploys/68bf24757e9668000811e037
😎 Deploy Preview https://deploy-preview-801--scientific-python-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94
Accessibility: 100
Best Practices: 100
SEO: 100
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the time back to 16:00 to correspond the UTC value for the summertime call. Otherwise this looks good.

Comment thread calendars/sunpy.yaml Outdated
Comment on lines +6 to +8
It is always at 5pm British Time (UTC+1 in the summer, UTC in the winter) on Wednesdays.
begin: 2022-07-20 17:00:00 +00:00
end: 2022-07-20 18:00:00 +00:00

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can handle it now, but please do open a feature request for the problem in https://github.com/scientific-python/yaml2ics

Comment thread calendars/sunpy.yaml Outdated
Comment on lines +6 to +8
It is always at 5pm British Time (UTC+1 in the summer, UTC in the winter) on Wednesdays.
begin: 2022-07-20 17:00:00 +00:00
end: 2022-07-20 18:00:00 +00:00

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, keep it as 16:00 as that will be the UTC for right now (and then in practice we go back and forth between the two time slot)

Comment thread calendars/sunpy.yaml Outdated
Comment thread calendars/sunpy.yaml Outdated
Comment thread calendars/sunpy.yaml Outdated
@nabobalis

Copy link
Copy Markdown
Member Author

I broke it, please hold.

Comment thread calendars/sunpy.yaml Outdated
@bsipocz

bsipocz commented Sep 8, 2025

Copy link
Copy Markdown
Member

OK, I see an error in the build: ("Error: must specify end date for " "repeating events"). Let me suggest another way to fix it

@nabobalis

Copy link
Copy Markdown
Member Author

I can just add it back?

Comment thread calendars/sunpy.yaml Outdated
nabobalis and others added 2 commits September 8, 2025 11:03
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
Comment thread calendars/sunpy.yaml Outdated
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
Comment thread calendars/sunpy.yaml Outdated
@bsipocz bsipocz merged commit 32e99c6 into scientific-python:main Sep 8, 2025
5 checks passed
@nabobalis nabobalis deleted the sunpy branch November 14, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants