Skip to content

Package library#19

Merged
stefanv merged 14 commits into
scientific-python:mainfrom
tupui:packaging
Mar 2, 2022
Merged

Package library#19
stefanv merged 14 commits into
scientific-python:mainfrom
tupui:packaging

Conversation

@tupui

@tupui tupui commented Feb 21, 2022

Copy link
Copy Markdown
Member

Closes #17 and supersed #18

  • Package using flit (cleanest for pure Python wheels)
  • Update Readme (considering changes from @rkdarst, thanks!)
  • Update CI and add release action (will need to add PyPi credentials for it to work). The tag is assumed to look like *.*, can be changed.
  • I released it on PyPi: https://pypi.org/project/yaml2ics/ (@jarrodmillman @stefanv let me know about your username on PyPi so I can add you as admin)

Note that dynamic links in dependencies are not supported on PyPi (Can't have direct dependency). Hence we need to tell users to handle it (see instructions in the Readme) until ics-py is updated and we can use a released version properly.

rkdarst and others added 7 commits February 20, 2022 15:35
- YAML provides & to label a node, and ways to refer to it.  This
  allows you to make one template event, and copy it many times
  changing only one property (such as the begin time.
- This adds an example of this into example/test_calendar.yaml
@tupui tupui self-assigned this Feb 21, 2022
@tupui tupui added this to the 0.1 milestone Feb 21, 2022
@rkdarst

rkdarst commented Feb 21, 2022

Copy link
Copy Markdown
Contributor

I approve of this license.
(and the work in general!)

@tupui

tupui commented Feb 21, 2022

Copy link
Copy Markdown
Member Author

I approve of this license.

For anyone reading, I just reformatted the file and added the mention this is MIT at the top (copy-pasted from another repo of the org). The text was not changed.

(and the work in general!)

Thanks for having a look 😃

@rkdarst rkdarst mentioned this pull request Feb 21, 2022
@jarrodmillman

Copy link
Copy Markdown
Member

My PyPI username is jarrodmillman: https://pypi.org/user/jarrodmillman/

Should we make it more clear that this isn't stable software and that people should be cautious if they want to use it now? I was imaging that we wouldn't release anything on PyPI for at least a month or two. If you want to make releases to PyPI now, maybe we should mark them as alpha, beta, rc1, etc. releases leading up to the first stablish 0.1 release at the end of May.

@tupui

tupui commented Feb 21, 2022

Copy link
Copy Markdown
Member Author

My PyPI username is jarrodmillman: pypi.org/user/jarrodmillman

I added you!

Should we make it more clear that this isn't stable software and that people should be cautious if they want to use it now? I was imaging that we wouldn't release anything on PyPI for at least a month or two. If you want to make releases to PyPI now, maybe we should mark them as alpha, beta, rc1, etc. releases leading up to the first stablish 0.1 release at the end of May.

Yes good idea to make it RC (will push soon to "fix" this, and I will add a more prominent note in the readme). I mostly pushed this already because people are mean nowadays and did not want someone squatting this name 😅

@tupui

tupui commented Feb 21, 2022

Copy link
Copy Markdown
Member Author

I added a warning box in the readme and pushed 0.1rc1 (and removed the other releases I pushed).

@stefanv stefanv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I just have a few minor pieces of comment.

Comment thread README.md Outdated
Comment thread .gitignore
@@ -1,2 +1,74 @@
*~
**/__pycache__
### Python template

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, this is a gynormous number of includes. Do we need all of these?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove most of it 👍

Comment thread LICENSE Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread example/test_calendar.yaml Outdated
Comment thread example/test_calendar.yaml Outdated
Comment thread .gitignore
@@ -1,2 +1,74 @@
*~
**/__pycache__
### Python template

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove most of it 👍

Comment thread LICENSE Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread example/test_calendar.yaml Outdated
Co-authored-by: Stefan van der Walt <sjvdwalt@gmail.com>
@tupui tupui requested a review from stefanv February 22, 2022 08:57
Comment thread .github/workflows/release.yml Outdated
@tupui

tupui commented Feb 22, 2022

Copy link
Copy Markdown
Member Author

FYI I changed the user/password to allow usage of a token. This is way better/more secure this way then since we can generate a token for this project only. (I don't have the rights to add one myself, but can share one offline if you want)

@tupui

tupui commented Feb 26, 2022

Copy link
Copy Markdown
Member Author

Ready for me @stefanv @jarrodmillman

@stefanv stefanv merged commit 1464735 into scientific-python:main Mar 2, 2022
@stefanv

stefanv commented Mar 2, 2022

Copy link
Copy Markdown
Member

Thanks @tupui!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make installable?

4 participants