yaml2ics: Allow a "timezone" option within each event.#22
Merged
Conversation
Contributor
Author
|
Black needed to be bumped, see the top of the description at psf/black#2964 This needs to be done anyway, if this isn't accepted I will make a separate PR. |
stefanv
reviewed
Apr 28, 2022
stefanv
left a comment
stefanv
left a comment
Member
There was a problem hiding this comment.
Looks good to me; I only suggested a small tweak to the test.
| assert "SUMMARY:New year" in cal_str | ||
| # It is possible that the ics-py TZID string changes, but hopefully this | ||
| # substring is fairly safe to test against. | ||
| assert "Europe/Helsinki:20220101T000000" in cal_str |
Member
There was a problem hiding this comment.
Might be worth asserting that New_York is not in there.
Contributor
Author
There was a problem hiding this comment.
Good point, I should have thought of that. Added.
stefanv
approved these changes
Apr 28, 2022
- I at first tried using the yaml datetime "+03:00" explicit offset. But, this created an output that worked in Google Calendar/Thunderbird, but not office 365 cloud. The problem seems to relate to the quoting of `"UTC +03:00"` in one place but not the other (and, as it turns out, it didn't work with either quotes there, or no quotes there!) - I had made the idea in this PR earlier, but didn't submit it because "less is more". But now this seems simpler (and more explicit somehow). - Changes are minimal and it just worked in one of my test casse. There is no effect if 'timezone' is not given in an event. - Review: decide if this is a good idea or not. Is there any simpler way to implement it?
- As described at the top of psf/black#2964
rkdarst
force-pushed
the
per-event-timezone
branch
from
de7ee0e to
8f620db
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
But, this created an output that worked in Google
Calendar/Thunderbird, but not office 365 cloud. The problem seems
to relate to the quoting of
"UTC +03:00"in one place but not theother (and, as it turns out, it didn't work with either quotes
there, or no quotes there!)
"less is more". But now this seems simpler (and more explicit
somehow).
There is no effect if 'timezone' is not given in an event.
way to implement it?