Skip to content

[MRG] Fix Github action version v2 -> v4 and fix test with skorch update#292

Merged
tgnassou merged 9 commits intoscikit-adaptation:mainfrom
tgnassou:fix_actions
Feb 20, 2025
Merged

[MRG] Fix Github action version v2 -> v4 and fix test with skorch update#292
tgnassou merged 9 commits intoscikit-adaptation:mainfrom
tgnassou:fix_actions

Conversation

@tgnassou
Copy link
Collaborator

@tgnassou tgnassou commented Feb 19, 2025

Change the version of GitHub action from v2 to v4.

Fix the test with DEV and deep method since the skorch updates change the type of NeuralNet.

@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.09%. Comparing base (ec2f00c) to head (fef9518).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (ec2f00c) and HEAD (fef9518). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (ec2f00c) HEAD (fef9518)
4 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #292       +/-   ##
===========================================
- Coverage   97.07%   77.09%   -19.98%     
===========================================
  Files          63       52       -11     
  Lines        6558     5921      -637     
===========================================
- Hits         6366     4565     -1801     
- Misses        192     1356     +1164     

@tgnassou tgnassou changed the title [WIP] Fix Github action version v2 -> v4 [WIP] Fix Github action version v2 -> v4 and fix test with skorch update Feb 20, 2025
@tgnassou
Copy link
Collaborator Author

The codecov is wrong. I tested locally and all is fine!

@tgnassou tgnassou changed the title [WIP] Fix Github action version v2 -> v4 and fix test with skorch update [MRG] Fix Github action version v2 -> v4 and fix test with skorch update Feb 20, 2025
@tgnassou tgnassou merged commit 485752e into scikit-adaptation:main Feb 20, 2025
6 of 7 checks passed
@tgnassou tgnassou deleted the fix_actions branch September 22, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant