[MRG] Add DeepDADataset#302
Merged
tgnassou merged 29 commits intoscikit-adaptation:mainfrom Jun 10, 2025
Merged
Conversation
creation of DeepDADataset class and main functionalities this version is without containers.
tgnassou
reviewed
Jun 2, 2025
skada/deep/base.py
Outdated
| X["sample_idx"] = sample_idx | ||
| return X, None | ||
| elif isinstance(X, Dataset): | ||
| try : |
Collaborator
There was a problem hiding this comment.
I don't really like the try here. What does it break sometime ?
skada/deep/base.py
Outdated
| sample_domain = dataset.get("sample_domain", sample_domain) | ||
| sample_weight = dataset.get("sample_weight", sample_weight) | ||
|
|
||
| dataset = DeepDADataset(X, y, sample_domain, sample_weight, device=self.device) |
Collaborator
There was a problem hiding this comment.
You creating a DeepDADAtaset inside itself ?
tgnassou
reviewed
Jun 6, 2025
skada/deep/base.py
Outdated
| self._initialize(X, y, sample_domain, sample_weight) | ||
|
|
||
| def _initialize(self, X:torch.Tensor, y, sample_domain, sample_weight): | ||
| try : |
Collaborator
There was a problem hiding this comment.
You can just try is 'sample_domain is None' ? If it's None you create a troch.full.
…nto mbarneche-deep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeepDADatasets is an attempt at unifying the different data representations used in skada deep