Skip to content

Include pack_train and pack_test in pack to get one method#317

Merged
tgnassou merged 37 commits intoscikit-adaptation:mainfrom
vloison:pack
Jun 25, 2025
Merged

Include pack_train and pack_test in pack to get one method#317
tgnassou merged 37 commits intoscikit-adaptation:mainfrom
vloison:pack

Conversation

@MellotApolline
Copy link
Contributor

@MellotApolline MellotApolline commented Jun 24, 2025

Fixes #189

@MellotApolline MellotApolline marked this pull request as ready for review June 24, 2025 14:02
@MellotApolline MellotApolline changed the title [WIP] Include pack_train and pack_test in pack to get one method Include pack_train and pack_test in pack to get one method Jun 24, 2025
@MellotApolline
Copy link
Contributor Author

MellotApolline commented Jun 24, 2025

@rflamary @antoinecollas @tgnassou PR is ready

@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 98.65772% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.58%. Comparing base (141b409) to head (1cf5fe9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
- Coverage   96.64%   96.58%   -0.06%     
==========================================
  Files          63       63              
  Lines        6910     6912       +2     
==========================================
- Hits         6678     6676       -2     
- Misses        232      236       +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@antoinecollas
Copy link
Collaborator

LGTM!
I have a last remark: can you add a warning block for the methods pack_train and pack_test to the documentation saying that the method is deprecated? It seems it's written nowhere in the doc.

@MellotApolline
Copy link
Contributor Author

LGTM! I have a last remark: can you add a warning block for the methods pack_train and pack_test to the documentation saying that the method is deprecated? It seems it's written nowhere in the doc.

Where would this warning block be? DomainAwareDataset is not in the API and modules section

@antoinecollas
Copy link
Collaborator

If you look at the doc: https://output.circle-artifacts.com/output/job/09e32606-b06a-44e5-9f63-4058d360e1cf/artifacts/0/dev/gen_modules/skada.datasets.DomainAwareDataset.html#skada.datasets.DomainAwareDataset.pack_train

then you see there is no message telling the user that pack_train and pack_test are deprecated.

@tgnassou tgnassou merged commit 716cbe6 into scikit-adaptation:main Jun 25, 2025
7 checks passed
@antoinecollas
Copy link
Collaborator

I was working on the PR to improve the warning in the doc. I'll re-open a new PR.

@antoinecollas
Copy link
Collaborator

See #336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get rid of pack_train and pack_test

5 participants