Include pack_train and pack_test in pack to get one method#317
Include pack_train and pack_test in pack to get one method#317tgnassou merged 37 commits intoscikit-adaptation:mainfrom
Conversation
…t_method_comparison
… of train argument
|
@rflamary @antoinecollas @tgnassou PR is ready |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
==========================================
- Coverage 96.64% 96.58% -0.06%
==========================================
Files 63 63
Lines 6910 6912 +2
==========================================
- Hits 6678 6676 -2
- Misses 232 236 +4 🚀 New features to boost your workflow:
|
|
LGTM! |
Where would this warning block be? DomainAwareDataset is not in the API and modules section |
|
If you look at the doc: https://output.circle-artifacts.com/output/job/09e32606-b06a-44e5-9f63-4058d360e1cf/artifacts/0/dev/gen_modules/skada.datasets.DomainAwareDataset.html#skada.datasets.DomainAwareDataset.pack_train then you see there is no message telling the user that |
|
I was working on the PR to improve the warning in the doc. I'll re-open a new PR. |
|
See #336 |
Fixes #189