Skip to content

[TO REVIEW] Update CONTRIBUTING.md#333

Merged
antoinecollas merged 2 commits intoscikit-adaptation:mainfrom
ambroiseodt:update_contributing
Jun 25, 2025
Merged

[TO REVIEW] Update CONTRIBUTING.md#333
antoinecollas merged 2 commits intoscikit-adaptation:mainfrom
ambroiseodt:update_contributing

Conversation

@ambroiseodt
Copy link
Contributor

@ambroiseodt ambroiseodt commented Jun 25, 2025

Update the dependency installation in CONTRIBUTING.md to solve the import problem for users using .venv virtual env and not conda virtual envs.

Update: the problem was coming from using zsh or bash terminal and not on the kind of virtual env used

@antoinecollas
Copy link
Collaborator

Is it related to venv vs conda or is it because of your terminal?
In some terminals, you need to escape brackets: pip install -e .\[dependance\]

@ambroiseodt
Copy link
Contributor Author

@antoinecollas good question, it needs to be tested (here the error was triggered with zsh while it worked for a bash terminal). What do you suggest as a global solution?

@antoinecollas
Copy link
Collaborator

antoinecollas commented Jun 25, 2025

I can merge it as it is. It was more about understanding where the problem comes from. And I think it comes from zsh.

@ambroiseodt
Copy link
Contributor Author

After some tests, I confirm that it comes from zsh. Adding the quotes works fine for any terminal so I think you can merge. Thanks

@antoinecollas antoinecollas merged commit 141b409 into scikit-adaptation:main Jun 25, 2025
7 checks passed
@ambroiseodt ambroiseodt deleted the update_contributing branch June 25, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants