[TO REVIEW] Update CONTRIBUTING.md#333
Merged
antoinecollas merged 2 commits intoscikit-adaptation:mainfrom Jun 25, 2025
Merged
Conversation
Collaborator
|
Is it related to venv vs conda or is it because of your terminal? |
Contributor
Author
|
@antoinecollas good question, it needs to be tested (here the error was triggered with zsh while it worked for a bash terminal). What do you suggest as a global solution? |
Collaborator
|
I can merge it as it is. It was more about understanding where the problem comes from. And I think it comes from zsh. |
Contributor
Author
|
After some tests, I confirm that it comes from zsh. Adding the quotes works fine for any terminal so I think you can merge. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the dependency installation in CONTRIBUTING.md to solve the import problem for users using .venv virtual env and not conda virtual envs.
Update: the problem was coming from using zsh or bash terminal and not on the kind of virtual env used