Skip to content

Fix tests when no VERSION file exists#44

Merged
jcfr merged 1 commit into
masterfrom
improve-tests
Jan 31, 2018
Merged

Fix tests when no VERSION file exists#44
jcfr merged 1 commit into
masterfrom
improve-tests

Conversation

@jcfr

@jcfr jcfr commented Jan 31, 2018

Copy link
Copy Markdown
Collaborator

No description provided.

@jcfr

jcfr commented Jan 31, 2018

Copy link
Copy Markdown
Collaborator Author

@lucasbrunialti Thanks for improving the tests. Our of curiosity, which workflow did you follow to produce the error fixed by this commit ?

@lucasbrunialti

Copy link
Copy Markdown
Contributor

I followed the steps in here (https://github.com/j0057/github-release#testing):

To execute the integration tests locally, and make sure your awesome contribution is working as expected, you will have to:

  • create a test repository with at least one commit (e.g yourname/github-release-test)
  • set environment variable INTEGRATION_TEST_REPO_NAME=yourname/github-release-test
  • execute python setup.py test

@lucasbrunialti

Copy link
Copy Markdown
Contributor

Created this repo with a initial commit: https://github.com/lucasbrunialti/github-release-test

@jcfr

jcfr commented Jan 31, 2018

Copy link
Copy Markdown
Collaborator Author

Makes sense. Thanks for the rapid feedback.

@jcfr jcfr merged commit 50af996 into master Jan 31, 2018
@jcfr jcfr deleted the improve-tests branch January 31, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants