451 python upgrade - #455
Conversation
|
Although unit tests pass using We should take this opportunity to update the Python dependencies defined in |
|
I am also seeing SyntaxWarnings related to escape sequences that were apparently introduced in Python 3.12. These might be resolved by making these instances raw string literals |
|
As of commit de80835, unit tests pass, but the workflow fails at SED fitting. |
|
For future reference, |
|
Unit tests pass at commit 1a5b3ae. @dhvanildesai Would you fix those SyntaxWarnings? Also, before we merge this, I want to reprocess one of the initial transients like 2026dgt and compare the exported data to v1.13.1. |
|
@djones1040 As of commit 1a5b3ae, the computed data for 2026dix is significantly different to my untrained eye. Take a look at the attached export files and see what you think: |
what differences are you seeing? Took only a quick glance but looks to me like photometry is the same, just things are in a different order (had to match up the filter PKs). Aperture orientation changed but -63 is the same as +297 so all good there (this is the photutils update probably). SED parameters are largely the same, and this is done via monte carlo sampling so we get some changes iteration to iteration. |
SyntaxWarnings fixed as of commit 0cc2433 |
Since they look similar enough to you to be considered "the same", then we will proceed with the merge. |
|
Thanks for noticing and fixing the Bokeh issue. I had already merged this branch into omnibus but neglected to explicitly state that here. I will cherry-pick this commit into that branch and it should be fine. I will move your second changelog entry from the "fixed" list into the "changed" list, because this was something you caused/discovered and fixed during the development cycle. In other words, it was never an actual "bug" that afflicted a public release. |
Resolves #451
Upgrading to python 3.13.14 instead of 3.14 to avoid major Django changes. I have also added
sparclclientandppxfas required packages, which are being used for fetching host galaxy spectra and spectral fitting.Also updated
Dockerfileto installgfortranfirst before anypipinstalls because otherwisefspshas build dependency issues.