You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On the .pyi file, I think the issue is with our common digital friend :) This year we started adding stubs so that code editors could auto-complete (see #1072), meaning that every function addiction must also come with a 1 or 2 line addition to the pyi file describing the input/output (forgot this step, sorry 😬 ). This is tedious, so I decided to create an automatic stub generator, that unfortunately is still a WIP, as you can see. The way forward is just telling the digital friend to roll back these pyi changes, and just add directly the consCumulative() ones, not using the stub generating script.
The reason will be displayed to describe this comment to others. Learn more.
Hey @tias , took the liberty to update your fork, all should be okay now. Thank you for your contribution, let me know if CPMpy needs any more help! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Joao,
Thanks for the very clear instructurions. With the help of a well-supervised digital friend I created a test-passing PR.
Does that look OK?
Note that I see tons of changes to 'src/pyscipopt/scip.pyi' but I think that is an artefact of code generation, I did not edit this file.
Even if good, don't merge it yet. We will first connect it to CPMpy so we can run our larger test-suite to make sure everything behaves appropriately.
Forgot to write that this is a follow-up to #1222