…say when AI didn't run (#147) * fix(ai): start the sample loop on a fresh launch, and let the report say when AI didn't run (I79) Issue #92 screenshotted a Windows session report with "Focused-time —", "No focus score was recorded", no ai_* timeline rows — and "No distractions detected. Nice work." right beside all of it. Root cause: useModelStore is never hydrated outside Settings → AI. hydrate() had exactly one caller, ModelPickerContainer's mount effect, and that component lives only in the Settings → AI pane. useSettingsStore is hydrated at boot by ThemeProvider, so aiFeaturesEnabled was correctly true while activeModelId sat at its null initial value — and activeModelId gates everything: SessionView's loop effect returns early on !activeModelId (so startSampleLoop never runs and its no_active_model toast can never fire), and Home's topic-submit skips the V2-P9 gesture-context screen pre-acquire on the same condition, which on WebView2 is separately fatal. Any launch without a Settings → AI visit ran a whole session with AI silently dead. Cross-platform, present at HEAD; also explains #94. Fixes, in the order a session hits them: - hydrate the model store in Home's boot effect - pre-acquire the screen stream from every real gesture that (re)boots the loop: topic submit, Rejoin, camera/mic "Try again"; a store mid-hydration counts as "maybe active" - toast once per session when AI is on, the store is ready, and no model is active — the gap onStartFail could never cover - onStalled: one notice per loop lifetime after 3 consecutive unproductive ticks, with a distinct reason and actionable copy per cause. Every path it covers was console.warn-only, and release builds have no devtools. Paused states are not stalls. - derive the per-tick timeout from the model's benchmarked p95 (3x, floored at 90s, capped at benchmark.ts's 300s). A model could benchmark successfully — the only thing that sets activeModelId — and then abort every live tick. - bound the screen acquire at 120s so an unanswered picker is a retryable error, not a permanent boot() wedge that also strands the sidecar - map InvalidStateError/InvalidAccessError to screen_capture_denied, whose overlay retry is itself the missing user gesture - migration 004 records sessions.ai_enabled, and aiCoverage() gives the report four honest states instead of one shrug: ran (keeps "Nice work"), noChecks (names the malfunction), off, unknown (pre-004). Shared with the text export. - Rust: resolve_runtime_dir falls back to the binary's own directory rather than None (None meant no CWD and no PATH prepend — the state I75 fixed), and the crash-loop give-up path carries the VC++ redist hint, which a child dying in the Windows loader never reached. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(ai): release the pre-acquired screen stream when a session never starts (I79) The V2-P9 gesture pre-acquire stashes a live screen MediaStream for boot() to consume, and the only release path was SessionView's unmount. Two paths reach a stash with no SessionView behind it, and this PR added one of them: - handleRejoin: joinSession() throws (bad stored credentials), the catch toasts, and status never flips to 'active'. - handleTopicSubmit + host: runHostInvite returns silently on its identity/display_name guard before hostSession() begins the session. Either way the OS screen-recording indicator stays lit with nothing behind it until the app quits. Discard on the rejoin failure, and don't pre-acquire at all when the host precondition already fails. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(db): record that sessions.ai_enabled is captured at teardown (I79) Comment-only on migration 004, whose hash is re-pinned in migrations.rs and re-manifested. Editing a .sql already in MANIFEST.sha256 is exactly what the forward-only guard blocks, and the escape hatch it documents applies here: 004 is new in this PR and has never shipped, so its manifest line was removed by hand before regenerating. The semantic worth stating: the column is the FINAL state of the AI toggle, not its state at session start. That is deliberate. The question it answers is "should the report explain an absence?", and aiCoverage() consults the sample counters first — so a session that recorded checks still reads as measured even if the user switched AI off before leaving, and only a session with nothing to show falls through to this column for its wording. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(ai): close the six gaps an adversarial sweep found in the I79 fix A 65-agent verification sweep over the first draft confirmed the root cause (two independent verifiers, cross-platform, still-broken at HEAD) and found six more defects on the same path: - hydrate()'s 'error' status was terminal. ModelPickerContainer retried only on 'loading', so a single failed models.json read (AV lock, partial write) left activeModelId null for the whole process — reopening #92 through a narrower door that fix A itself widened. Gate is now status !== 'ready', and the session notice distinguishes "no model picked" from "model list unreadable". - The footer chip read "AI off" while AI was ON with no model. That was the only on-screen signal during #92 and it pointed at the wrong setting. New 'unconfigured' status behind a pure deriveAiChipStatus(), with 'loading' deliberately reading 'off' so no launch flashes a warning during hydration. - aiCoverage returned 'ran' for confident_samples 0 with skipped_samples k, on the argument that the #47 D5 data-quality line caveats it. It does not below SKIPPED_SAMPLES_MIN (3): for k of 1-2 the page rendered "Focused-time —", no caveat, and "No distractions detected. Nice work." — this issue's own defect surviving its own fix. Fifth state 'noConfident'; the two tests that asserted the old behaviour are edited, not appended to. - append_windows_dll_hint probed only vcruntime140.dll, so it stayed silent on a machine with the C runtime but not the C++ one. Requires both now. - next_attempts resets the restart streak whenever a child clears MIN_HEALTHY_UPTIME, so a sidecar dying every ~2.5 minutes crash-looped forever and never set errored: the stall notice fired once and the session then ran an hour on a dying engine. TOTAL_RESTART_BUDGET (12 per generation) closes it, sized so an 8-hour session dying hourly never trips while a 121s cycle trips at ~24 minutes. - Settings → Sessions marks an unmeasured row "not measured" when ai_enabled is 1, never inferring it for 0 or NULL. One finding rejected: "onSidecarErrored re-arms every tick, so a flapping sidecar re-toasts forever". errored is cleared only by sidecar_start/stop and the watcher returns after setting it, so errored→running requires deliberate user action — re-notifying then is correct, as the existing test documents. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * style: re-format with the prettier the lockfile actually pins (3.9.5) The merge from main brought prettier 3.9.5 into package-lock.json, but this working tree still had 3.8.3 installed from the pre-merge lockfile. Every `npm run format` I ran after the merge therefore rewrote files — including nine that belong to main and that this PR never meant to touch — in 3.8.3 style, and CI's Frontend job failed its Format check against 3.9.5. `npm ci` + `npm run format` restores all nine to byte-identical with main and formats the two files this PR does own. The diff against main is now exactly the 36 intended files. Worth remembering: `format:check` compares against the LOCKFILE's prettier, so a stale node_modules turns a formatting pass into a formatting regression. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(issues): correct the I83 aiCoverage state and test counts Round 2 added a fifth coverage state (noConfident) and grew the aiCoverage/serializer suites, but the ledger entry still described the first draft's four states and 6/4 case counts. Keeps 'pre-003 scored row' as-is: that case is about migration 003's sample counters, not 004's ai_enabled. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Ai feature log for sessions broken on windows #92

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions