Skip to content

fix(session): recover PTT from a dropped release - #168

Merged
scotej merged 1 commit into
mainfrom
agent/fix-ptt-release-recovery
Aug 2, 2026
Merged

fix(session): recover PTT from a dropped release#168
scotej merged 1 commit into
mainfrom
agent/fix-ptt-release-recovery

Conversation

@scotej

@scotej scotej commented Aug 2, 2026

Copy link
Copy Markdown
Owner

What changed

  • Treat a second physical PTT press while transmission is latched as an emergency mute.
  • Cancel the stale 120-second failsafe instead of re-arming and extending the hot-mic window.
  • Add regression coverage for immediate recovery, timer cleanup, and a clean subsequent hold.
  • Record the production finding in the issue ledger.

Why

If the global shortcut's Released edge is dropped, the store remains active. Before this change, every recovery press kept the microphone live and restarted the two-minute guard. This gives users an immediate app-level recovery path while preserving normal hold-to-talk behavior.

Fixes #156

Validation

  • npm run build
  • npm run lint
  • npm test — 86 files, 1,055 tests
  • npm run format:check
  • token, string, migration, story, and contrast guard scripts
  • npm run build-storybook
  • focused PTT suite — 13 tests

The browser a11y suite could not run locally because this environment cannot download the Playwright Chromium binary; GitHub Actions remains the authoritative run. A macOS host was not available for a packaged-app manual reproduction.

Copilot AI review requested due to automatic review settings August 2, 2026 22:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@scotej, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1a33fdf2-aa8f-4386-81d7-37bbf2a4e891

📥 Commits

Reviewing files that changed from the base of the PR and between 48ddc41 and d7e1a4c.

📒 Files selected for processing (3)
  • ISSUES.md
  • src/stores/pttStore.ts
  • tests/unit/ptt-store.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Push to talk

2 participants