Remove nebula bitmap limit#5128
Merged
Merged
Conversation
Baezon
approved these changes
Jan 18, 2023
Baezon
added
enhancement
BMagnu
removed
the
Waiting for Stable
Goober5000
added a commit
to Goober5000/fs2open.github.com
that referenced
this pull request
Jul 17, 2025
This allows the first half of a modular -neb.tbm to be skipped, allowing just poofs to be specified without the need for a preceding empty bitmap section. It's a follow-up to scp-fs2open#5128 which allowed just bitmaps to be specified without the need for a subsequent empty poof section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes MAX_NEB2_BITMAPS which was previously just 10; a limit I hit just but modularizing the MediaVPs nebula.tbl which only adds three bitmaps to retail's 8. Instead of simply raising the limit this PR vectorizes the bitmap list. Bitmaps are only ever referenced by name (unlike poofs which use flags) so it makes sense to just make this a quick vector of strings.
Sneaks in one small QoL parsing feature to check for end of file in a modular table so that -neb.tbms which don't specify poofs won't require two #end lines.