a few pstypes changes and refinements#6506
Merged
Merged
Conversation
Goober5000
added
cleanup
Goober5000
force-pushed
the
pstypes_changes
branch
4 times, most recently
from
c8aa664 to
911edfb
Compare
Goober5000
force-pushed
the
pstypes_changes
branch
from
911edfb to
4fd7fc2
Compare
wookieejedi
approved these changes
Jan 8, 2025
wookieejedi
left a comment
wookieejedi
left a comment
Member
There was a problem hiding this comment.
Looks good and works in my tests
Contributor
Author
|
Putting this in draft until #6465 is merged, due to probable merge conflicts. |
Goober5000
force-pushed
the
pstypes_changes
branch
2 times, most recently
from
8ef6a51 to
e1acfc2
Compare
Goober5000
force-pushed
the
pstypes_changes
branch
from
e1acfc2 to
141d03a
Compare
Several changes related to the volumetrics model fix: 1. Update the `model_load()` prototype with better parameter names, including a new `ErrorType` enum defined in pstypes.h 2. Update the `MIN`, `MAX`, and `CLAMP` macros, all of which were susceptible to performance issues because they duplicated their tokens. This could cause functions or calculations to be re-run unnecessarily. Since the codebase is now on C++17, `std::clamp()` can be used. 3. Update the rest of the codebase to fix any associated issues.
Goober5000
force-pushed
the
pstypes_changes
branch
from
141d03a to
ca624f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several changes related to the volumetrics model fix:
model_load()prototype with better parameter names, including a newErrorTypeenum defined in pstypes.hMIN,MAX, andCLAMPmacros, all of which were susceptible to performance issues because they duplicated their tokens. This could cause functions or calculations to be re-run unnecessarily. Since the codebase is now on C++17,std::clamp()can be used.Currently in draft as this depends on #6505.