Unify Particle Attachment#6571
Merged
Merged
Conversation
wookieejedi
approved these changes
Feb 2, 2025
wookieejedi
left a comment
Member
There was a problem hiding this comment.
Tests with new and existing features all work as expected. Also, highly useful features that further enhance the options for particle creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A followup to #6465.
Note: This is not a behavioural change wrt. to 24.2, but it is a small change to current nightly. As such, it'd be great to include it in 25.0 as to avoid needing a flag to guard the behaviour change.
The main change, apart from a few tiny bugfixes, is that this PR will properly "parent" particle sources to things.
For example, impact spew and other similar particles were just anchored in space, rather than at the ship that was spewing. This has multiple detrimental effects:
Additionally, some particle sources that could not be parented (for example because the parent is dying) are being supplied the radius of the ship manually to allow access from modular curves.
Furthermore, modular curves are now supplied "trigger radius" and "trigger velocity".
This means, for example on weapon impact, a modder has access to both the velocity and radius of the particle host (the ship being hit), and the velocity and radius of the triggering object (in this case, the weapons radius and velocity) in modular curves.