Fix SDL3_compat-caused flicker#6767
Merged
Merged
Conversation
BMagnu
added
fix
JohnAFernandez
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With modern SDL, notably SDL3-compat for SDL2 API, but possibly also slightly newer SDL2 versions, reading from the frontbuffer just doesn't work and just yields zeroes.
Unfortunately, screenshots and pause dialogs rely on that feature.
However, if we route things through an intermediate buffer (as we already need to do to fix fullscreen weirdness of Windows 11), this isn't an issue.
As such, just unconditionally enable this through window_res.