Cleanup of Level 0 Particles#6808
Merged
Merged
Conversation
…urve input for particles
… more commonly intended variamnt
BMagnu
added
enhancement
This was referenced Jul 5, 2025
wookieejedi
approved these changes
Jul 8, 2025
wookieejedi
left a comment
wookieejedi
left a comment
Member
There was a problem hiding this comment.
Tests look good and overall great to have this cleanup and new features fully implemented!
This was referenced Jul 10, 2025
wookieejedi
added a commit
to wookieejedi/fs2open.github.com
that referenced
this pull request
Jul 28, 2025
scp-fs2open#6808 converted all Pspews to use the new particle effects, though that in turn lead to a fun little visual bug. Overall, particles on weapons will only be rendered if they are valid, and the is valid check included a `weapon_state == m_weaponstate` check (IE states had to match between what the weapon object held and what the particle held. When a weapon switches to homing that particle state was never updated, b/c before 6808 it never needed to be. This lead to the particle effects from pspews not rendering when a missile was in homing mode. This PR fixes that issue by also updating the particle host status whenever the weapon state changes (uses the same logic as when the particle spawns the first time). Tested and works as expected.
wookieejedi
added a commit
that referenced
this pull request
Jul 28, 2025
#6808 converted all Pspews to use the new particle effects, though that in turn lead to a fun little visual bug. Overall, particles on weapons will only be rendered if they are valid, and the is valid check included a `weapon_state == m_weaponstate` check (IE states had to match between what the weapon object held and what the particle held. When a weapon switches to homing that particle state was never updated, b/c before 6808 it never needed to be. This lead to the particle effects from pspews not rendering when a missile was in homing mode. This PR fixes that issue by also updating the particle host status whenever the weapon state changes (uses the same logic as when the particle spawns the first time). Tested and works as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #6465.
Closes #3049, Fixes #2321.
TL;DR of the user-facing changes and improvements:
This adds the level 0 particle cleanup mentioned in the particle rework.
Notably, this means that all particles are now spawned exclusively from static particle effects. No bit of the code is still creating particles ad-hoc. This allows to reduce the amount of data stored in each particle by giving the particle access to the static effect data it was spawned from. Furthermore, this access allows for much more flexible particle behaviour, as outlined in the original PR.