Skip to content

Remove rocket ani assertion#6852

Merged
JohnAFernandez merged 1 commit into
scp-fs2open:masterfrom
MjnMixael:fix_rocket_ani_assertion
Jul 23, 2025
Merged

Remove rocket ani assertion#6852
JohnAFernandez merged 1 commit into
scp-fs2open:masterfrom
MjnMixael:fix_rocket_ani_assertion

Conversation

@MjnMixael

Copy link
Copy Markdown
Contributor

Downgrade this assertion to an early return. All this function does is advance the frame. If this isn't an animation there's no need to throw up roadblocks here. Simply don't try to advance the frame.

Allows element types "ani" to work with both static images and animations simultaneously which is important because we don't have a way to distinguish between png and apng since we don't work with 4 char extensions fundamentally in cfile.

Fixes an issue in SCPUI for Event Horizon.

@MjnMixael MjnMixael added this to the Release 25.0 milestone Jul 21, 2025
@MjnMixael MjnMixael added the Requested by Active Mod A feature request that has been requested by a mod that is actively in development. label Jul 21, 2025
@JohnAFernandez JohnAFernandez merged commit 1d5fa5e into scp-fs2open:master Jul 23, 2025
20 checks passed
@MjnMixael MjnMixael deleted the fix_rocket_ani_assertion branch July 23, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Requested by Active Mod A feature request that has been requested by a mod that is actively in development.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants