Fix screenToBlob with Regards to Current RTT State#6867
Merged
Conversation
BMagnu
added
fix
Contributor
|
Thanks for this! I'm confirming the fix works on my end as well. |
wookieejedi
approved these changes
Jul 26, 2025
wookieejedi
left a comment
wookieejedi
left a comment
Member
There was a problem hiding this comment.
Tests report fix works as noted above, approving.
Kestrellius
pushed a commit
to Kestrellius/fs2open.github.com
that referenced
this pull request
Jul 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6846.
This now explicitly checks and correctly processes the current RTT state when calling screenToBlob.
The problem was originally caused due to #6753 no longer being able to rely on the current implicit OpenGL state and had to explicitly set FBO's. This, if not considered, would effectively "unbind" the current RTT texture, and thus just blob the main screen rather than the current RTT target.
With proper FBO and Color attachment settings for RTT, this also fixes #5436 properly.