Give Particles Access to Their Spawner Effect#7034
Merged
Conversation
BMagnu
added
enhancement
wookieejedi
approved these changes
Sep 15, 2025
wookieejedi
left a comment
wookieejedi
left a comment
Member
There was a problem hiding this comment.
Existing particles all still worked in my test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #6465.
The particles having access to their static table data is an important enhancement for a lot of particle use cases.
Explicitly, this PR closes #3052 by ways of modular curves that are now possible, and it will facilitate both #3046 and #6863 in followup PRs.
As a side effect, this PR gives modular curves the ability to call global functions that use the previously received value as an argument.
This PR also cleans out the old particle spawn logic, which is no longer necessary with the new particle system being the only source of particles.
Even though every particle has to access the particle manager and query it for the particle effect, this PR had no measurable performance difference on a 300k particle stress test.