Fix FRED resetting the grid position after saving a mission#7552
Open
Goober5000 wants to merge 1 commit into
Open
Fix FRED resetting the grid position after saving a mission#7552Goober5000 wants to merge 1 commit into
Goober5000 wants to merge 1 commit into
Conversation
When FRED2 saves a mission, OnSaveDocument() reloads it via load_mission(MPF_FAST_RELOAD). That reload calls clear_mission() -> fred_render_init() -> create_default_grid(), which rebuilds The_grid as the default origin-centered XZ plane, discarding any adjustments made in the Adjust Grid dialog (e.g. the X-Z Plane Y Level). The grid is editor display state and is not stored in the mission file, so the reload had nothing to restore it from. The camera (view_pos/view_orient) is already preserved across this reload; apply the same preserve-and-restore pattern to the grid by capturing its orientation, center, dimensions, and square size before clear_mission() and rebuilding it with create_grid() afterward. qtfred is unaffected because its save path does not reload the mission. Fixes scp-fs2open#7548 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Goober5000
added
fix
wookieejedi
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When FRED2 saves a mission, OnSaveDocument() reloads it via load_mission(MPF_FAST_RELOAD). That reload calls clear_mission() -> fred_render_init() -> create_default_grid(), which rebuilds The_grid as the default origin-centered XZ plane, discarding any adjustments made in the Adjust Grid dialog (e.g. the X-Z Plane Y Level). The grid is editor display state and is not stored in the mission file, so the reload had nothing to restore it from.
The camera (view_pos/view_orient) is already preserved across this reload; apply the same preserve-and-restore pattern to the grid by capturing its orientation, center, dimensions, and square size before clear_mission() and rebuilding it with create_grid() afterward.
qtfred is unaffected because its save path does not reload the mission.
Fixes #7548