make brief_stage non-copyable and non-movable; provide swap() and reset()#7557
Open
Goober5000 wants to merge 1 commit into
Open
make brief_stage non-copyable and non-movable; provide swap() and reset()#7557Goober5000 wants to merge 1 commit into
Goober5000 wants to merge 1 commit into
Conversation
…et() brief_stage owns its icons and lines buffers through raw pointers, so the implicitly generated copy/move operations silently alias those buffers across two stages. Delete them and provide a custom swap() that exchanges members (keeping each slot with a distinct buffer), plus a reset() that restores the default-constructed state. Update brief_compact_stages, the only code that assigned brief_stage objects: shift stages down by swapping (equivalent, since the removed stage buffers were already freed and the tail is cleared afterward) and clear the tail entries with reset(). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Goober5000
added
cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brief_stage owns its icons and lines buffers through raw pointers, so the implicitly generated copy/move operations silently alias those buffers across two stages. Delete them and provide a custom swap() that exchanges members (keeping each slot with a distinct buffer), plus a reset() that restores the default-constructed state.
Update brief_compact_stages, the only code that assigned brief_stage objects: shift stages down by swapping (equivalent, since the removed stage buffers were already freed and the tail is cleared afterward) and clear the tail entries with reset().