Prevent tab and label wrapping#2545
Merged
chrisgarrity merged 1 commit intoJul 9, 2018
Merged
Conversation
Fixes scratchfoundation#2448 (tab wrapping in Japanese). Also ensures that none of the Sprite info area wraps. Does not address the issue where the sprite info area is too big and pushes the stage info off the screen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Proposed Changes
Describe what this Pull Request does
Adds
white-space: nowrapto the tab labels and labels in the sprite info area.Reason for Changes
Explain why these changes should be made
These areas are not designed for text wrapping and the results are unpredictable.
Test Coverage
Usual tests run.
Try is out: https://chrisgarrity.github.io/scratch-gui/issue/2448-ja-overflow/?locale=ja
Browser Coverage
Check the OS/browser combinations tested (At least 2)
Mac
Windows
Chromebook
iPad
Android Tablet