[MASTER] Temporarily exclude RTL languages from the menu#2706
Merged
chrisgarrity merged 1 commit intoJul 23, 2018
Conversation
Currently that’s just hebrew. It’s still available with the `?locale=he` for people to check translations. It’s being temporarily excluded from the menu until we have RTL support for the interface.
rschamp
approved these changes
Jul 23, 2018
Contributor
|
@chrisgarrity Don't forget to also merge this into |
chrisgarrity
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right to left (RTL) languages are not yet fully supported in the editor, so we don't want to give the impression they are by including them in the menu.
Translators can still load the language with the
?locale=heURL argument.Currently the excluded languages is just 'he', but I wanted to write it in such a way that it can be used for multiple languages later if we need it.