Skip to content

Always use sans-serif#2750

Merged
fsih merged 1 commit into
scratchfoundation:developfrom
apple502j:patch-3
Aug 9, 2018
Merged

Always use sans-serif#2750
fsih merged 1 commit into
scratchfoundation:developfrom
apple502j:patch-3

Conversation

@apple502j
Copy link
Copy Markdown
Contributor

@apple502j apple502j commented Aug 1, 2018

Resolves

Resolves #2373

Proposed Changes

If HelveticaNeue is not available, use sans-serif fonts instead of Times New Roman (or any serif font).

Reason for Changes

It defaults to serif font!

@towerofnix
Copy link
Copy Markdown
Contributor

towerofnix commented Aug 1, 2018

By the way, you can put "Resolves #2373" or "Fixes #2373" instead of just the issue number to make the issue be automatically closed when it's merged in, so that nobody needs to actually remember to close the issue (which can sometimes leave issues being open for a while, as you noticed in #2751).

Copy link
Copy Markdown
Contributor

@fsih fsih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; thanks!

@fsih fsih merged commit 3f4053e into scratchfoundation:develop Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants