Skip to content

[DEVPLAT-6703] Bump go version to v1.26.2#162

Merged
Neurostep merged 5 commits into
mainfrom
maksimt/DEVPLAT-6703/bump-go
Apr 22, 2026
Merged

[DEVPLAT-6703] Bump go version to v1.26.2#162
Neurostep merged 5 commits into
mainfrom
maksimt/DEVPLAT-6703/bump-go

Conversation

@Neurostep
Copy link
Copy Markdown
Contributor

@Neurostep Neurostep commented Apr 21, 2026

Description

In this PR we are bumping the go version to v1.26.2.

Alongside we also bump some dependencies needed for formatting, linting, and debugging.

Additionally, the go fix ./... was executed to update the code base to use modern Go syntax style.

Checklist

  • Prefixed the PR title with the JIRA ticket code
  • Performed simple, atomic commits with good commit messages
  • Verified that the commit history is linear and commits are squashed as necessary
  • Thoroughly tested the changes in development and/or staging
  • Updated the README.md as necessary

Related links


Note

Medium Risk
Medium risk due to a Go toolchain upgrade plus widespread mechanical signature/type tweaks (interface{}any) and small concurrency/logging refactors that could cause subtle build or behavior differences across the SDK surface.

Overview
Upgrades the SDK toolchain to Go 1.26.2 (Docker build image, go.mod, and README) and refreshes dev tooling versions (golangci-lint, goimports, dlv).

Applies gofix-style modernizations across the codebase: broad interface{}any updates in public APIs (logger, transport encode/decode funcs, gRPC interceptors, config helpers), uses standard-library helpers like maps.Copy, min, fmt.Appendf, strings.SplitSeq, range N, and WaitGroup.Go, and removes a few temporary variables/formatting steps while keeping log messages equivalent.

Reviewed by Cursor Bugbot for commit e57c7dd. Bugbot is set up for automated code reviews on this repo. Configure here.

@Neurostep Neurostep requested a review from a team as a code owner April 21, 2026 13:32
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e57c7dd. Configure here.

Comment thread pkg/logger/kafka/kafka.go
logEntry.Infof(msg, args...)
case kgo.LogLevelDebug:
logEntry.Debugf(msg)
logEntry.Debugf(msg, args...)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead empty args slice masks format string misuse

Low Severity

The args variable is created as an empty slice and never populated, then spread into every Errorf/Warnf/Infof/Debugf call. This is dead code that only serves to silence the Go 1.24+ go vet "non-constant format string with no args" check. Since msg from kgo.Logger.Log is a plain message string (not a format string), the correct approach is logEntry.Errorf("%s", msg) — which both properly silences the diagnostic and prevents % characters in msg from being misinterpreted as format verbs.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e57c7dd. Configure here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is relevant but pretty minor thus we can ignore it

@Neurostep Neurostep merged commit e6f9dfc into main Apr 22, 2026
9 checks passed
@Neurostep Neurostep deleted the maksimt/DEVPLAT-6703/bump-go branch April 22, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants