review patch 12636: height of blank lines

[luzpaz]

From @aoloe on August 29, 2014 12:12

http://bugs.scribus.net/view.php?id=12636

Copied from original issue: scribusproject/scribus-old-to-be-deleted#7

[luzpaz]

We should really make this a PR but since repo still needs to be sync'd then this should do for now. For convenience I've added the patch contents below for review

--- scribus15/scribus/pageitem_textframe.cpp-   2014-08-14 19:53:53.305452890 +0200
+++ scribus15/scribus/pageitem_textframe.cpp    2014-08-28 05:26:48.477446205 +0200
@@ -2013,6 +2013,13 @@
                            int ol2 = static_cast<int>(ol1 / m_Doc->guidesPrefs().valueBaselineGrid);
                            current.yPos = ceil(  ol2 / 10000.0 ) * m_Doc->guidesPrefs().valueBaselineGrid + m_Doc->guidesPrefs().offsetBaselineGrid - by;
                        }
+                       else if (chstr[0] == SpecialChars::PARSEP)
+                       {
+                           // 28Aug14 William Bader increment by current font size instead of default line spacing to match Scribus 1.4
+                           double incCharAscentHeight = font.ascent(style.charStyle().fontSize() / 10.0);
+                           current.yPos += incCharAscentHeight;
+                           //current.yPos += style.lineSpacing();
+                       }
                        else
                            current.yPos += style.lineSpacing();
                    }

[luzpaz]

From @aoloe on August 29, 2014 13:4

my thoughts:

at least:

• reformat the date
• remove the out commented line
• remove the reference to scribus 1.4: we should check if the change is correct, not if it does the same as 1.4

[luzpaz]

per jghali:
Closing as this is an issue in 14x that we won't reintroduce in 1.5.x.