Conversation
✅ Deploy Preview for scroll-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
Need to adjust for modification where Router will use ETHGateway. |
Thegaram
reviewed
Feb 6, 2024
isabellewei
previously approved these changes
Feb 7, 2024
| --- | ||
|
|
||
| import ClickToZoom from "../../../../../components/ClickToZoom.astro" | ||
| import Aside from "../../../../../components/Aside.astro" |
| - We will now use constants to store some companion contract addresses, instead of using storage variables. This is possible since these values should (almost) never change. With this change we can save on a few storage load operations. | ||
| - We updated the intrinsic gas estimation in `L1MessageQueue` to use a simple upper bound instead of an exact calculation. The two results will be similar for most bridge transactions but the new implementation is significantly cheaper. | ||
| - We merged two contracts `L1MessageQueue` and `L2GasPriceOracle` to save on call costs from one contract to the other. | ||
|
|
Contributor
There was a problem hiding this comment.
should we also mention that the Gateway Router contract will directly call the Scroll Messenger contract instead of ETH Gateway for ETH deposits?
Contributor
Author
There was a problem hiding this comment.
(This change was reverted after OZ audits)
|
|
||
| When messaging from L1 to L2, the user pays all transaction fees on L1. The user pays L1 gas fees, but because of this, doesn't need to pay Scroll an L1 Data Fee. They will need to account for L2 Execution Fees in their L1 transaction though, and will need to know how much L2 gas to pay. | ||
|
|
||
| Contracts on L1 can use an L2 Gas Price Oracle deployed to the L1 to get the gas fee for a given transaction. The oracle also exposes the current l2BaseFee and estimated cross-domain message fee for a given gas limit. |
Contributor
There was a problem hiding this comment.
could be helpful to add that you can estimate the gas limit with eth_estimateGas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial updates notifying of Sepolia bridge update and the upcoming mainnet update.
Should not be pushed to prod until the article is published and links are updated.
Additional Follow-ups:
zhfor prod