refactor: restructure examples#221
Merged
Merged
Conversation
Collaborator
|
Cool, thank you very much! We will gladly merge this one after the integration-tests run. Interestingly, there is now a missing dependency for the examples, see the failing tests. If you could add it to the deps again, the CI should work. |
Collaborator
|
Unfortunately, there has been another issue popping up in the examples. I would be great if you could fix that. :) Sorry for nitpicking here. |
clangenb
approved these changes
Mar 15, 2022
Collaborator
clangenb
left a comment
clangenb
left a comment
There was a problem hiding this comment.
Thanks for the cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change just restructures the examples.
Putting example code in the examples/ folder automatically make it a runnable example.
There is also no need to make the files executable.