Add and rename significance thresholds - #974
Merged
Merged
Conversation
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #974 +/- ##
==========================================
+ Coverage 73.54% 77.76% +4.21%
==========================================
Files 48 48
Lines 5613 6372 +759
==========================================
+ Hits 4128 4955 +827
+ Misses 1485 1417 -68
🚀 New features to boost your workflow:
|
Collaborator
Author
Member
|
2x yes. But you may also introduce scverse-misc and use https://scverse-misc.readthedocs.io/stable/generated/scverse_misc.deprecated_arg.html |
Collaborator
Author
LuisHeinzlmeier
commented
May 31, 2026
Collaborator
Author
There was a problem hiding this comment.
Ready for a review! I also updated the notebooks, but couldn't push them into this PR because I am working on a forked repo. This time, I will create a separate PR in pertpy-tutorials (see here).
LuisHeinzlmeier
marked this pull request as ready for review
May 31, 2026 06:55
This was referenced May 31, 2026
Merged
Zethson
approved these changes
Jun 1, 2026
This was referenced Aug 4, 2026
Zethson
added a commit
that referenced
this pull request
Aug 4, 2026
* Rename DistanceTest alpha to padj_threshold Closes #1002 Aligns DistanceTest with the significance threshold naming introduced in #974, where alpha became padj_threshold in Milo, the DGE base and enrichment. alpha stays accepted and now emits a FutureWarning. DIALOGUE is left alone as requested in the issue. * Bump tutorials submodule for the padj_threshold rename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.










plot_fold_change()#967alpha,thres, etc. with consistent parameter names, where appropriate_pydeseq2.pyand_milo.pybecause lazy loading of packages (probably PyDESeq2) pre-appends ignoring all future warnings (also thescverse_miscwarnings from pertpy)plot_fold_change()by adding.copy()