Skip to content

fix table name and add unit test for colors passed via .uns #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ArneDefauw wants to merge 13 commits into from
Closed

fix table name and add unit test for colors passed via .uns #413

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b5cb026
fix table name and add unit test
ArneDefauw Jan 28, 2025
0f2663e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 28, 2025
0d4867c
uncomment matplotlib use agg
ArneDefauw Jan 28, 2025
6c04b11
Merge branch 'fix_table_name' of github.com:ArneDefauw/spatialdata-pl…
ArneDefauw Jan 28, 2025
2dfb47c
category not deterministic in unit test
ArneDefauw Jan 28, 2025
bd39e7e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 28, 2025
39038e9
matplotlib
ArneDefauw Jan 28, 2025
2f449f4
Merge branch 'fix_table_name' of github.com:ArneDefauw/spatialdata-pl…
ArneDefauw Jan 28, 2025
5af65aa
import
ArneDefauw Jan 28, 2025
1c58719
fix for keyerror
ArneDefauw Jan 28, 2025
6a33304
tests
ArneDefauw Jan 29, 2025
6d9a590
move rng, fix tests
ArneDefauw Jan 29, 2025
be331f3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[pre-commit.ci] auto fixes from pre-commit.com hooks 
for more information, see https://pre-commit.ci
  • Loading branch information
@pre-commit-ci
pre-commit-ci[bot] committed Jan 29, 2025
commit be331f3446447239e698c899522083cdec226b38
4 changes: 2 additions & 2 deletions tests/pl/test_render_labels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ def test_plot_label_categorical_color_and_colors_in_uns_query_uns_colors_removed
# Why? Because `.bounding_box_query` removes "category_colors" that are not in the query,
# but restores original number of catergories in `.obs["category"]`, see https://github.com/scverse/anndata/issues/997,
# leading to mismatch and removal of "category_colors" by `.filter_by_coordinate_system`.
assert all(sdata_blobs["other_table"].obs["category"].unique() == [ "a", "c" ])
assert all(sdata_blobs["other_table"].obs["category"].unique() == ["a", "c"])
assert all(sdata_blobs["other_table"].uns["category_colors"] == ["#800080", "#FFFF00"])
# but due to https://github.com/scverse/anndata/issues/997:
assert all(sdata_blobs["other_table"].obs["category"].cat.categories == ["a", "b", "c"])
Expand All @@ -259,7 +259,7 @@ def test_plot_label_categorical_color_and_colors_in_uns_query_workaround(self, s
max_coordinate=[100, 100],
target_coordinate_system="global",
)
assert all(sdata_blobs["other_table"].obs["category"].unique() == [ "a", "c" ])
assert all(sdata_blobs["other_table"].obs["category"].unique() == ["a", "c"])
assert all(sdata_blobs["other_table"].uns["category_colors"] == ["#800080", "#FFFF00"])
# but due to https://github.com/scverse/anndata/issues/997:
assert all(sdata_blobs["other_table"].obs["category"].cat.categories == ["a", "b", "c"])
Expand Down
Loading