Now raising an error if color or table doesn't exist#515
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
==========================================
- Coverage 83.88% 83.33% -0.56%
==========================================
Files 8 8
Lines 2259 2322 +63
==========================================
+ Hits 1895 1935 +40
- Misses 364 387 +23
🚀 New features to boost your workflow:
|
t import at runtime
Member
Author
|
@LucaMarconato I assume this will have implications in our tutorials if we're blindly plotting elements that are not annotated. |
Member
|
No problems, I'll catch errors with tutorials. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now raising errors on missing input and if no table at all annotates the element.
In the process, I noticed we sometimes
warnfrom our logger and sometimes fromwarnings, so I got rid ofwarnings. Then, I had to adjust the capturing of the logged messages, so I added that helper as well.