ci: fail fast on integration test binary cache miss - #447
Merged
wprzytula merged 1 commit intoMay 9, 2026
Conversation
In run https://github.com/scylladb/cpp-rs-driver/actions/runs/25594930991, the build job successfully built the integration test binary but failed to save it to the GitHub Actions cache (transient cache service timeout). The test jobs then silently proceeded without the binary, and build-integration-test-bin-if-missing attempted to rebuild from source without build dependencies (libuv) installed, producing an unrelated CMake error that was difficult to diagnose. Set `fail-on-cache-miss: true` on the cache restore steps so that test jobs fail immediately with a clear error when the binary is not available, instead of falling through to a doomed rebuild attempt.
There was a problem hiding this comment.
Pull request overview
This PR hardens CI behavior in .github/workflows/build-lint-and-test.yml so integration test jobs fail immediately when the cached integration-test binary is unavailable, avoiding confusing fallback rebuild failures when build dependencies aren’t present in test runners.
Changes:
- Configure
actions/cache/restore@v4tofail-on-cache-miss: truefor integration test binary restores in both Scylla and Cassandra integration test jobs. - Add inline rationale comments explaining the failure mode and recommended recovery (re-run the build job).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lorak-mmk
approved these changes
May 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In run https://github.com/scylladb/cpp-rs-driver/actions/runs/25594930991, the build job successfully built the integration test binary but failed to save it to the GitHub Actions cache (transient cache service timeout). The test jobs then silently proceeded without the binary, and build-integration-test-bin-if-missing attempted to rebuild from source without build dependencies (libuv) installed, producing an unrelated CMake error that was difficult to diagnose.
Set
fail-on-cache-miss: trueon the cache restore steps so that test jobs fail immediately with a clear error when the binary is not available, instead of falling through to a doomed rebuild attempt.Pre-review checklist
[ ] I have implemented Rust unit tests for the features/changes introduced.[ ] I have enabled appropriate tests inMakefilein{SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.[ ] I added appropriateFixes:annotations to PR description.