Add working Debug impl for caching session#1161
Merged
wprzytula merged 2 commits intoscylladb:mainfrom Dec 29, 2024
Merged
Conversation
|
|
The previous derived implementation was not actually usable because it had `Debug` bounds on the type parameters. The `RandomState` default value for the `S` argument does not impl `Debug`, so this didn't work. This commit switches to a manual `Debug` impl that doesn't have these unnecessary bounds.
athre0z
force-pushed
the
caching-session-debug-impl
branch
from
c5a8fcc to
dc2e939
Compare
Lorak-mmk
approved these changes
Dec 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous derived implementation was not actually usable because it had
Debugbounds on the type parameters. TheRandomStatedefault value for theSargument does not implDebug, so this didn't work.This commit switches to a manual
Debugimpl that doesn't have these unnecessary bounds.Pre-review checklist
./docs/source/.Fixes:annotations to PR description.