Skip to content

data-types.md improvements#1474

Merged
Lorak-mmk merged 4 commits intoscylladb:mainfrom
Lorak-mmk:fix-data-types-docs
Nov 14, 2025
Merged

data-types.md improvements#1474
Lorak-mmk merged 4 commits intoscylladb:mainfrom
Lorak-mmk:fix-data-types-docs

Conversation

@Lorak-mmk
Copy link
Collaborator

@Lorak-mmk Lorak-mmk commented Nov 14, 2025

data-types.md had some issues:

  • For Decimal CQL type, nonexisting bigdecimal::Decimal type was specified, instead of bigdecimal::BigDecimal.
  • Borrowed versions of CqlVarint and CqlDecimal were not mentioned.

Additionally, in #1376 user requested to add information about feature flags to the types that require them.
I tried to do this, but resulting page looked clutter imo. Instead, I added a note about some types requiring feature flags, guiding users to the chapters for more details.

Fixes: #1376

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@Lorak-mmk Lorak-mmk requested a review from wprzytula November 14, 2025 12:50
@Lorak-mmk Lorak-mmk self-assigned this Nov 14, 2025
@Lorak-mmk Lorak-mmk added this to the 1.5.0 milestone Nov 14, 2025
@github-actions
Copy link

cargo semver-checks found no API-breaking changes in this PR.
Checked commit: a66b439

@Lorak-mmk Lorak-mmk merged commit 9306a35 into scylladb:main Nov 14, 2025
14 checks passed
@wprzytula wprzytula mentioned this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Issue on page Data Types

2 participants