-
Notifications
You must be signed in to change notification settings - Fork 146
First batch of metadata improvements #1526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
bd25c6f
speculative_execution_is_fired: Fix test
Lorak-mmk 8f3231b
metadata: Extract querying to separate module
Lorak-mmk 9d99037
metadata: Extract reader to separate module
Lorak-mmk 7824ef1
Remove connection pool from MetadataReader
Lorak-mmk f5d0e6d
Create ControlConnection eagerly
Lorak-mmk 2d2416e
Introduce ControlConnectionState
Lorak-mmk c0a1d00
Move events channel to cc state
Lorak-mmk 9ea80c6
Move channel polling to MetadataReader
Lorak-mmk ed6db82
MetadataReader: group fields into config and state
Lorak-mmk 0e74022
Store MetadataError in ControlConnectionState::Broken
Lorak-mmk a4dfc29
Make control connection state the source of truth
Lorak-mmk 6a06b40
Move UntranslatedEndpoint into ControlConnectionState
Lorak-mmk 7d82d41
make_control_connection: Return state
Lorak-mmk 8c8ff40
Make reader and fetching submodules of metadata
Lorak-mmk fd72f91
Add doc-comments for new metadata sub-modules
Lorak-mmk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Add doc-comments for new metadata sub-modules
- Loading branch information
commit fd72f91d5e73216bf40543defac60cc4597efcab
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lorak-mmk marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.