Change defaults for SCYLLA_URI* env variables#1555
Merged
Lorak-mmk merged 3 commits intoscylladb:mainfrom Jan 19, 2026
Merged
Conversation
|
|
Lorak-mmk
force-pushed
the
scylla_uri_defaults
branch
from
9daaab6 to
f138cd8
Compare
wprzytula
requested changes
Jan 19, 2026
We bascially always run tests / examples against our dockerized cluster. It will greatly improve ergonomics to not have to pass the values directly.
This aims to make development easier. Typically, developers run the cluster from our docker compose, using `make up`. It would be great for default URIs to match that, in order to not require passing `SCYLLA_URI`. This requires changing CI: either to pass SCYLLA_URI, or to use the docker cluster. For consistency, using docker cluster seemes like a better option to me.
Now that the default match the docker IPs (172.42.0.2/3/4) we don't need to pass them explicitly.
Lorak-mmk
force-pushed
the
scylla_uri_defaults
branch
from
f138cd8 to
4532bdc
Compare
wprzytula
approved these changes
Jan 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We pretty much always run everything with our dockerized cluster. It is frustrating to have to pass those variables - it will be much better if we just switch the defaults.
Fixes: #1553
Ref: #1552
Pre-review checklist
I added relevant tests for new features and bug fixes../docs/source/.Fixes:annotations to PR description.