Add Introduction to Security Testing

[madanalogy]

Resolves #131

[jamessspanggg]

It seems like the netlify preview doesn't show the intro to security chapter in the table of contents. Can you add it in so that we can view the chapter on netlify?

[jamessspanggg]

Some general comments:

1. Add the chapter to the initial table of contents.
2. Perhaps the diagrams can be slightly smaller? Currently takes a lot of space.
3. Label the diagrams.
4. Perhaps can give examples for the types of security testing in the What is Security Testing section?

[jamessspanggg]

Some more comments:

[jamessspanggg]

LGTM now :) do request a review from me again if there's any major changes

[madanalogy]

LGTM now :) do request a review from me again if there's any major changes

Gotcha, thanks! :)

[damithc]

Good start. Added some comments. Need to make the contents stronger. Try to base your content on a authoritative source (e.g., a popular textbook on the topic) so that the reader can be more confident about what is being read. In other words, don't let the reader worry if you might be inventing your own theory. Give a topic X, things such as 'types of X' 'objectives of X' have well-established answers. Just need to find those from a good source, adapt it to your context, and cite the source.

[madanalogy]

Good start. Added some comments. Need to make the contents stronger. Try to base your content on a authoritative source (e.g., a popular textbook on the topic) so that the reader can be more confident about what is being read. In other words, don't let the reader worry if you might be inventing your own theory. Give a topic X, things such as 'types of X' 'objectives of X' have well-established answers. Just need to find those from a good source, adapt it to your context, and cite the source.

Most of the content was lifted from an authoritative source. I should've included proper citations and references apologies for that oversight. I will go through your comments and make the necessary changes, thank you!

[madanalogy]

Hi @jamessspanggg will need your review again as there's been an overhaul of the chapter following comments from @damithc. Main changes:

• Rephrased most content to be more accurate to the source material
• Included proper citations and references to source material
• Changed the images to be more meaningful
• Reworded headings to be more consistent as previously suggested

The chapter structure however is largely the same. Additionally, would appreciate if you have any comments on the appropriateness of the At A Glace sub-section under the Security Testing in Action section. Thank you! :)

[jamessspanggg]

Good improvements from the previous revision. Some comments;

[j-lum]

Overall looks good. The 'At a glance' section can benefit from having a bit more references.

[madanalogy]

Overall looks good. The 'At a glance' section can benefit from having a bit more references

I adapted them from the OWASP Testing Guide so it's really mostly referenced from there haha

[madanalogy]

@tiuweehan hope you have time to provide the final review for this book chapter, thanks!

[tiuweehan]

Looks good to me! The article is well-structured and easy to read. Not much to add since most of the issues have been pointed out by other reviewers, just a few suggestions.

[madanalogy]

@damithc chapter ready for merging! :)

[damithc]

@openorclose any idea what's going on in the footnotes here? known bug to be fixed in future?

[madanalogy]

@openorclose any idea what's going on in the footnotes here? known bug to be fixed in future?

That was not there when I reviewed it locally with markbind serve. I am currently on markbind version 2.12.0 if that helps.

[openorclose]

@openorclose any idea what's going on in the footnotes here? known bug to be fixed in future?

It's a bug, fixed in MarkBind/markbind#1155

[damithc]

It's a bug, fixed in MarkBind/markbind#1155

Thanks for checking @openorclose
I'll merge this then.