Array subset works with flat arrays;#2781
Conversation
| return 0; | ||
| } | ||
| } | ||
| if ($other_value > $subset_value) return 1; |
There was a problem hiding this comment.
Inline control structures are not allowed
|
Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it because I do not understand the issue (see #2069 (comment)) you're trying to solve here. |
|
(1) The issue was (and is) that the (2) The second issue is that the subset must be in the same order in both suubset and the original array. FYI. During tests had been running on this branch there were some errors not related to this feature. |
|
I am faced issues with auto indexed arrays today, what was solution? Fails sometimes, because array with email has different int index. https://phpunit.de/manual/6.5/en/appendixes.assertions.html#appendixes.assertions.assertArraySubset |
Add possibility to check flat arrays within assertArrayContains
Fixes #2069