Feature/method covers overrides class covers nothing#3115
Merged
sebastianbergmann merged 3 commits intoMay 7, 2018
Merged
Conversation
…e 'class covers nothing' annotation.
Codecov Report
@@ Coverage Diff @@
## master #3115 +/- ##
============================================
+ Coverage 81% 81.01% +<.01%
- Complexity 2914 2917 +3
============================================
Files 109 109
Lines 7630 7639 +9
============================================
+ Hits 6181 6189 +8
- Misses 1449 1450 +1
Continue to review full report at Codecov.
|
Contributor
|
Really glad to see this, thanks @Danack, nice work here ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements sebastianbergmann/php-code-coverage#611 aka allows a 'method covers' annotation to override the 'class coversNothing' annotation.
Reasonably chance this might need to wait until PHPUnit 7.2.0