Skip to content

adding file and lineno to "useless test"-message#3198

Merged
sebastianbergmann merged 7 commits into
sebastianbergmann:masterfrom
Idrinth:master
Jul 7, 2018
Merged

adding file and lineno to "useless test"-message#3198
sebastianbergmann merged 7 commits into
sebastianbergmann:masterfrom
Idrinth:master

Conversation

@Idrinth

@Idrinth Idrinth commented Jul 6, 2018

Copy link
Copy Markdown
Contributor

I believe this should be sufficient to solve #1801
I would consider it to be a breaking change, since the output format changes, possibly making tools based on the current one unable to work.

@codecov-io

codecov-io commented Jul 6, 2018

Copy link
Copy Markdown

Codecov Report

Merging #3198 into master will increase coverage by 0.14%.
The diff coverage is 78.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3198      +/-   ##
============================================
+ Coverage     82.23%   82.37%   +0.14%     
+ Complexity     3509     3507       -2     
============================================
  Files           140      140              
  Lines          9231     9231              
============================================
+ Hits           7591     7604      +13     
+ Misses         1640     1627      -13
Impacted Files Coverage Δ Complexity Δ
src/Framework/TestSuite.php 85.43% <77.61%> (+0.62%) 148 <0> (-3) ⬇️
src/Framework/TestResult.php 75.38% <88.88%> (+2.63%) 164 <0> (+1) ⬆️
src/Framework/TestFailure.php 83.78% <0%> (+2.7%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17423b...4ab1703. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit 585939e into sebastianbergmann:master Jul 7, 2018
@sebastianbergmann sebastianbergmann added this to the PHPUnit 7.3 milestone Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants