Skip to content

Various repo fixes#1

Merged
bennettgoble merged 4 commits into
secondlife:masterfrom
FelixWolf:CZ-1
Nov 18, 2022
Merged

Various repo fixes#1
bennettgoble merged 4 commits into
secondlife:masterfrom
FelixWolf:CZ-1

Conversation

@FelixWolf

Copy link
Copy Markdown
Contributor

These fixes include:

  1. Dark theme compatible markdown that uses black on white text if light theme(original), or the white on black text if dark theme(addition). The addition is version I modified to match that of the forum's dark theme:
    Old:
    Screenshot_20221118_063059
    New:
    Screenshot_20221118_063121

Issues: I have no idea if bitbucket supports HTML markdown. By markdown standard, it should, but would be worth double checking if bitbucket is still intended to be pushed to.

  1. LGPL-licence.txt renamed to LGPL-license.txt. Licence is the verb to give a license, License is the noun of a document. (Note, github sees this as a file move for some reason)
  2. Added copy of LGPL-license.txt as LICENSE.txt so that github recognizes it as a license and displays it as such on the sidebar. (Note, github sees this as a new file for some reason)

@bennettgoble

Copy link
Copy Markdown
Contributor

Hey, @FelixWolf. Thanks for the PR. Could you pull in the latest changes from master in order to incorporate our new CLA bot?

@bennettgoble bennettgoble left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, could you use LICENSE instead of LICENSE.txt? This would match the name being used in our other public repositories such as autobuild and leap. :)

@github-actions

github-actions Bot commented Nov 18, 2022

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@FelixWolf

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@FelixWolf FelixWolf closed this Nov 18, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 18, 2022
@bennettgoble bennettgoble reopened this Nov 18, 2022
@secondlife secondlife deleted a comment from FelixWolf Nov 18, 2022

@bennettgoble bennettgoble left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The README looks much better in dark mode now.

@bennettgoble bennettgoble merged commit 783926e into secondlife:master Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants