build: isolate gnullvm Windows Rust exec toolchain - #572
Draft
GraciousGazelles wants to merge 12 commits into
Draft
build: isolate gnullvm Windows Rust exec toolchain#572GraciousGazelles wants to merge 12 commits into
GraciousGazelles wants to merge 12 commits into
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
GraciousGazelles
force-pushed
the
fix/native-windows-health-and-cache-20260801
branch
2 times, most recently
from
August 1, 2026 08:49
d8f26e8 to
9da4076
Compare
GraciousGazelles
force-pushed
the
fix/native-windows-health-and-cache-20260801
branch
from
August 2, 2026 02:47
6a0047f to
9c7184f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Native Windows Bazel builds compile gnullvm proc-macro DLLs.
rules_rsv0.0.96 only registers a generic Windows execution toolchain, so toolchain resolution can select an MSVC-hosted Rust runtime for those DLLs. That ABI mismatch makes otherwise materialized proc macros unloadable and is reported byrustcas missing crates (E0463).//:local_windowsinherits the runner CPU. Registering only the x86_64 gnullvm compiler execution triple therefore leaves ARM64 Windows hosts without a full-ABI-compatible Rust action toolchain. The fallback must be an ARM64 gnullvm toolchain, not an MSVC toolchain.The native Windows health run at
9da40763eda9731d23d60216f566280c7ac394f8also found an OTLP HTTP current-thread Tokio shutdown timeout. ExplicitOtelProvider::shutdown()was followed byDrop, which repeated the exporter shutdown path before the test runtime could report completion.What changed
rules_rspatch that registersx86_64-pc-windows-gnullvmandaarch64-pc-windows-gnullvmas distinct Rust compiler-tools execution ABIs.MODULE.bazel.lockthrough Bzlmod.bazel aqueryjob to the native health workflow. It parses the text-format result into clearly delimited action blocks and verifies exactly oneRustcaction for//codex-rs/otel:otel: that same action must report the ARM64 gnullvm execution platform and gnullvm rustc/Cargo inputs, and must not report ARM64 MSVC inputs.bazel test //..., diagnostics, cache isolation, and serialization.OtelProvider::shutdown()idempotent and let tracer-provider shutdown perform its own flush, preventing a second flush/shutdown after explicit shutdown andDrop.MODULE.bazel.lockand cover the workflow and patch contract in planner tests.Validation
patch --dry-run --fuzz=0against the releasedrules_rsv0.0.96 archive.python3 -m unittest discover -s .github/scripts -p test_ci_planners.pypython3 .github/scripts/test_run_bazel_with_buildbuddy.pypython3 .github/scripts/check_workflow_policy.pyjust bazel-lock-updateandjust bazel-lock-checkcargo metadata --manifest-path codex-rs/Cargo.toml --locked --no-deps --format-version 1rustfmt --check --edition 2024 codex-rs/file-watcher/src/file_watcher_tests.rsbazel query //codex-rs/file-watcher:file-watcher-unit-testsbazel build --nobuild //codex-rs/file-watcher:file-watcher-unit-testsgit diff --check,rustfmt --edition 2024 --check codex-rs/otel/src/provider.rs codex-rs/otel/src/provider_shutdown_tests.rs,cargo metadata --manifest-path codex-rs/otel/Cargo.toml --no-deps --format-version 1, andbazel query //codex-rs/otel:otel-tests-test-windows-cross.just bazel-lock-update,just bazel-lock-check,python3 -m unittest discover -s .github/scripts -p test_ci_planners.py, andgit diff --check.python3 .github/scripts/test_verify_arm64_gnullvm_aquery.py -v,python3 -m unittest discover -s .github/scripts -p 'test_*.py'(275 tests),python3 .github/scripts/check_workflow_policy.py,python3 -m py_compile .github/scripts/verify_arm64_gnullvm_aquery.py .github/scripts/test_verify_arm64_gnullvm_aquery.py, andgit diff --check.python3 -m unittest discover -s .github/scripts -p 'test_*.py'(276 tests),python3 .github/scripts/check_workflow_policy.py,python3 -m py_compile .github/scripts/test_ci_planners.py .github/scripts/test_run_bazel_with_buildbuddy.py, andgit diff --check.git diff --checkHosted Native Windows Bazel health acceptance is pending for the exact updated PR head.